[PATCH] D30532: Add examples to clang-format configuration

Sylvestre Ledru via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Thu Mar 2 06:53:08 PST 2017


sylvestre.ledru added inline comments.


================
Comment at: docs/ClangFormatStyleOptions.rst:218
+
+    #define A   \
+    int aaaa;   \
----------------
klimek wrote:
> Do we really align these 3 spaces out?
nope, bad copy and paste it seems. Sorry


================
Comment at: docs/ClangFormatStyleOptions.rst:447
+     SomeClass::Constructor()
+     : a(a)
+     , b(b)
----------------
klimek wrote:
> Don't we align the : further to the right?
Yes, sorry, issue during the copy and paste :(



================
Comment at: docs/ClangFormatStyleOptions.rst:517
+
+     namespace a {} // namespace a;
+
----------------
klimek wrote:
> I thought we don't do that for single lines?
Yes and no. I reported this bug:
https://bugs.llvm.org//show_bug.cgi?id=32117
I will update the example to avoid the confusion



https://reviews.llvm.org/D30532





More information about the cfe-commits mailing list