[PATCH] D30523: [libc++] Mark some std::num_get method templates inline

Shoaib Meenai via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Wed Mar 1 18:52:53 PST 2017


smeenai created this revision.

https://reviews.llvm.org/D29157 will make explicit template instantiations expand to default
visibility, at which point these method templates will need to be
explicitly marked hidden visibility to avoid leaking into other DSOs.
Unfortunately, because of clang PR32114, they must be marked inline (in
conjunction with `-fvisibility-inlines-hidden`) to actually hide them,
since clang doesn't respect the hidden visibility annotation.

Since this involves an ABI change, mark these methods inline in a
separate change, so that the ABI changes can be reviewed separately and
verified to be safe.


https://reviews.llvm.org/D30523

Files:
  include/locale
  lib/abi/CHANGELOG.TXT
  lib/abi/x86_64-unknown-linux-gnu.abilist

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D30523.90270.patch
Type: text/x-patch
Size: 9671 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20170302/2d3a58bc/attachment.bin>


More information about the cfe-commits mailing list