[PATCH] D30087: [Driver] Unify linking of OpenMP runtime

[Hal Finkel via Phabricator via cfe-commits]

hfinkel added inline comments.


================
Comment at: lib/Driver/Tools.cpp:10334
 
-      if (Args.hasFlag(options::OPT_fopenmp, options::OPT_fopenmp_EQ,
-                       options::OPT_fno_openmp, false)) {
+      // FIXME: Exclude this for platforms with libgomp that don't require
+      // librt. Most modern Linux platforms require it, but some may not.
----------------
Now that you've moved the comment, it is not clear what "this" means here. Please reword this to say that you should only pass true for GompNeedsRT on platforms that really need it.


https://reviews.llvm.org/D30087