[PATCH] D27387: [libc++] Add a key function for bad_function_call

Eric Fiselier via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Tue Feb 28 23:23:21 PST 2017


EricWF added inline comments.


================
Comment at: include/functional:1393
+public:
+    virtual ~bad_function_call() _NOEXCEPT;
+
----------------
smeenai wrote:
> EricWF wrote:
> > What's the rationale for making the dtor out-of-line? Couldn't we just use `what()` as the key function?
> We could, but this way it's consistent with all the other exception classes.
OK works for me. since it's a virtual function we probably won't see any benefits from inlining. 


https://reviews.llvm.org/D27387





More information about the cfe-commits mailing list