[PATCH] D27387: [libc++] Add a key function for bad_function_call

[Eric Fiselier via Phabricator via cfe-commits]

EricWF added inline comments.


================
Comment at: include/functional:1393
+public:
+    virtual ~bad_function_call() _NOEXCEPT;
+
----------------
What's the rationale for making the dtor out-of-line? Couldn't we just use `what()` as the key function?


================
Comment at: lib/CMakeLists.txt:162
 
-# Add a object library that contains the compiled source files.
+# Add an object library that contains the compiled source files.
 add_library(cxx_objects OBJECT ${exclude_from_all} ${LIBCXX_SOURCES} ${LIBCXX_HEADERS})
----------------
smeenai wrote:
> This may seem like a completely unrelated change, but it's actually important to force cmake to get re-run so that the glob for source files picks up on the new file.
Glad you're on top of this :-)


================
Comment at: src/functional.cpp:11
+#include "__config"
+#ifdef _LIBCPP_ABI_BAD_FUNCTION_CALL_KEY_FUNCTION
+
----------------
Nit, please put the guard inside of the namespace at the smallest possible scope.

Also there is no need to manually include `__config` before including `functional`.


https://reviews.llvm.org/D27387