[PATCH] D26949: [libc++abi] Clean up visibility

[Shoaib Meenai via Phabricator via cfe-commits]

smeenai added inline comments.


================
Comment at: src/abort_message.h:19
 
-__attribute__((visibility("hidden"), noreturn))
-       void abort_message(const char* format, ...) 
-            __attribute__((format(printf, 1, 2)));
-
+_LIBCXXABI_HIDDEN __attribute__((noreturn)) void
+abort_message(const char *format, ...) __attribute__((format(printf, 1, 2)));
----------------
EricWF wrote:
> `LIBCXXABI_NORETURN`?
That would also require changing the `__cxxabi_config.h` include to a `cxxabi.h` include (since that's where `_LIBCXXABI_NORETURN` is defined). Is that acceptable?


https://reviews.llvm.org/D26949