[PATCH] D29157: [libc++] Make _LIBCPP_EXTERN_TEMPLATE_TYPE_VIS export members

Eric Fiselier via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Tue Feb 28 16:33:25 PST 2017


EricWF added inline comments.


================
Comment at: include/string:1100
     template<class _InputIterator>
+        inline _LIBCPP_INLINE_VISIBILITY
         typename enable_if
----------------
smeenai wrote:
> EricWF wrote:
> > Why `inline _LIBCPP_INLINE_VISIBILITY` here but `_LIBCPP_HIDDEN` everywhere else?
> This function is really small, so I figured marking it for inlining was more appropriate.
This should probably have _LIBCPP_INLINE_VISIBILITY on it then.


https://reviews.llvm.org/D29157





More information about the cfe-commits mailing list