[PATCH] D30326: [MS-ABI] Allow #pragma section to choose for ZI data

Javed Absar via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Mon Feb 27 09:33:49 PST 2017


javed.absar updated this revision to Diff 89897.
javed.absar added a comment.

Hi Roger:
Thanks for the review. I have extended the test and fixed driver flag passing that you pointed out.

Regarding the check in Sema::DeclarationIsZeroInitialized, the check if to keep the function return value consistent, in case function is called with a declaration that is without an initializer.
Best Regards, 
Javed


https://reviews.llvm.org/D30326

Files:
  include/clang/AST/APValue.h
  include/clang/AST/Expr.h
  include/clang/Basic/LangOptions.def
  include/clang/Driver/Options.td
  include/clang/Sema/Sema.h
  lib/AST/APValue.cpp
  lib/AST/Expr.cpp
  lib/Driver/Tools.cpp
  lib/Frontend/CompilerInvocation.cpp
  lib/Sema/SemaDecl.cpp
  test/CodeGenCXX/zi-sections.cpp
  test/Driver/always-use-bss.c

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D30326.89897.patch
Type: text/x-patch
Size: 15698 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20170227/4b32e8c6/attachment-0001.bin>


More information about the cfe-commits mailing list