[PATCH] D29437: [ubsan] Detect signed overflow UB in remainder operations

Eli Friedman via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Fri Feb 24 11:51:40 PST 2017


efriedma added inline comments.


================
Comment at: lib/CodeGen/CGExprScalar.cpp:2380
+       CGF.SanOpts.has(SanitizerKind::SignedIntegerOverflow)) &&
+      Ops.Ty->isIntegerType()) {
     CodeGenFunction::SanitizerScope SanScope(&CGF);
----------------
I don't think you need the isIntegerType check here?


https://reviews.llvm.org/D29437





More information about the cfe-commits mailing list