[PATCH] D30239: enable -flto=thin in clang-cl

Hans Wennborg via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Thu Feb 23 17:00:34 PST 2017


hans added inline comments.


================
Comment at: test/Driver/cl-options.c:532
+// RUN: %clang_cl -### -Fe%t.exe -entry:main -flto -- %s 2>&1 | FileCheck -check-prefix=LTO-WITHOUT-LLD %s
+// LTO-WITHOUT-LLD: invalid argument '-flto' only allowed with '-fuse-ld=lld'
+
----------------
This is nit-picky, but "invalid argument" doesn't sound great to me here; -flto isn't invalid, it's the lack of -fuse-ld=lld that's the problem.

Maybe just adding a new "err_drv_flto_without_lld" that says somethihng like "'-flto' without '-fuse-ld=lld' is not supported" would be better?


https://reviews.llvm.org/D30239





More information about the cfe-commits mailing list