r296027 - Tighten up a regex in a test

George Burgess IV via cfe-commits cfe-commits at lists.llvm.org
Thu Feb 23 14:14:56 PST 2017


Author: gbiv
Date: Thu Feb 23 16:14:55 2017
New Revision: 296027

URL: http://llvm.org/viewvc/llvm-project?rev=296027&view=rev
Log:
Tighten up a regex in a test

...If we're trying to match "this function has only two arguments", `.*`
probably isn't the best thing to use. :)

Modified:
    cfe/trunk/test/CodeGenObjCXX/arc-attrs-abi.mm

Modified: cfe/trunk/test/CodeGenObjCXX/arc-attrs-abi.mm
URL: http://llvm.org/viewvc/llvm-project/cfe/trunk/test/CodeGenObjCXX/arc-attrs-abi.mm?rev=296027&r1=296026&r2=296027&view=diff
==============================================================================
--- cfe/trunk/test/CodeGenObjCXX/arc-attrs-abi.mm (original)
+++ cfe/trunk/test/CodeGenObjCXX/arc-attrs-abi.mm Thu Feb 23 16:14:55 2017
@@ -25,7 +25,7 @@ struct VirtualBase2 {
 // emit the construction code inline.
 struct WithVirtualBaseMid : virtual VirtualBase2 {
   // Ensure we only pass in `this` and a vtable. Otherwise this test is useless.
-  // ITANIUM: define {{.*}} void @_ZN18WithVirtualBaseMidCI212VirtualBase2EP11objc_objectPv({{.*}}, {{.*}})
+  // ITANIUM: define {{.*}} void @_ZN18WithVirtualBaseMidCI212VirtualBase2EP11objc_objectPv({{[^,]*}}, {{[^,]*}})
   using VirtualBase2::VirtualBase2;
 };
 struct WithVirtualBaseLast : WithVirtualBaseMid {




More information about the cfe-commits mailing list