[PATCH] D15227: [analyzer] Valist checkers.

[Gábor Horváth via Phabricator via cfe-commits]

xazax.hun added a comment.

In https://reviews.llvm.org/D15227#681127, @zaks.anna wrote:

> >   But as far as I remember, this produced false negatives in the tests not false positives.
>
> Could you double check that? Maybe you still have some notes in your mail box or just by looking at the code.
>
> Did none of the checks work or just some of them?
>
> Also, which platforms did this not work on?
>
> It would be great to move all of the useful checks out of alpha since alpha essentially means "unsupported" and we do not recommend turning those checkers on.
>
> Thanks!


I think I managed to solve the problems due to the different AST variants. In the future this should be abstracted away by the analyzer core. You can see the patch here: https://reviews.llvm.org/D30157

Early next week I will rerun this check on a larger open source project. If it does not give me too much false positives or crash, I think it is a good candidate to move out from alpha.


Repository:
  rL LLVM

https://reviews.llvm.org/D15227