[PATCH] D29757: [libcxx] Threading support: Externalize hardware_concurrency()

[Eric Fiselier via Phabricator via cfe-commits]

EricWF requested changes to this revision.
EricWF added a comment.
This revision now requires changes to proceed.

Same comment as https://reviews.llvm.org/D29818

I really don't like this change (and https://reviews.llvm.org/D29818) because they start to include a ton of extra headers, and because they lift complex configuration logic into what should be a very simple header.
These functions are much better suited to being define out-of-line for a number of reasons.

Is there another way we can allow "external implementations" of these functions without lifting everything into a header?


https://reviews.llvm.org/D29757