[PATCH] D29685: Lit C++11 Compatibility - Function Attributes

[Delesley Hutchins via Phabricator via cfe-commits]

delesley added a comment.

I agree with Aaron here.  Those thread safety errors are supposed to fire; simply disabling the unit tests because they no longer fire is not acceptable.  I also don't understand how this could be a bug with the thread safety analysis, since these particular errors are issued when the attributes are parsed, not when the analysis is run.   I haven't looked at the relevant code in a long time; have there been significant changes to the attribute-parsing mechanism?  There's no member initialization going on here, so why would changes to member initialization have this side effect?  I'm confused.

  DeLesley


https://reviews.llvm.org/D29685