[PATCH] D29755: Cache FileID when translating diagnostics in PCH files

Akira Hatanaka via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Sun Feb 12 23:04:07 PST 2017


ahatanak added inline comments.


================
Comment at: lib/Frontend/ASTUnit.cpp:2551
       continue;
-    FileID FID = SrcMgr.translateFile(FE);
+    FileID FID;
+    if (FE == CachedFE) {
----------------
Since FID is always equal to CachedFID, I think you can simplify this a bit by removing FID and using just CachedFID.


https://reviews.llvm.org/D29755





More information about the cfe-commits mailing list