[PATCH] D29685: Lit C++11 Compatibility - Function Attributes

Aaron Ballman via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Sun Feb 12 06:23:46 PST 2017


aaron.ballman added a reviewer: delesley.
aaron.ballman added a subscriber: delesley.
aaron.ballman added a comment.

The changes to the format string look good to me, but the changes to the thread-safety attributes do not make sense. I *think* those are indicative of a bug with thready safety analysis, but @delesley would have the definitive answer there. I'm not certain how a static function or variable can be safely guarded by an instance member.


https://reviews.llvm.org/D29685





More information about the cfe-commits mailing list