[PATCH] D29863: [libc++] Fix PR 31938 - std::basic_string constructors use non-deductible parameter types.

Eric Fiselier via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Sat Feb 11 02:50:23 PST 2017


EricWF updated this revision to Diff 88088.
EricWF added a comment.

- Fix the initializer list constructors.
- Add tests for almost every constructor.

The following two examples still do not work:

  std::basic_string s1("hello world", 2); // deduces Allocator = int
  std::basic_string s2("hello world", 0, 2); // deduces Allocator = int

This is because the `Allocator` argument is not normally deduced, and
therefore would not normally accept an integer argument.


https://reviews.llvm.org/D29863

Files:
  include/string
  test/std/strings/basic.string/string.cons/implicit_deduction_guides.pass.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D29863.88088.patch
Type: text/x-patch
Size: 11559 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20170211/eb39e17b/attachment-0001.bin>


More information about the cfe-commits mailing list