[PATCH] D15227: [analyzer] Valist checkers.

Gábor Horváth via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Sat Feb 11 01:30:16 PST 2017


xazax.hun added a comment.

In https://reviews.llvm.org/D15227#674278, @zaks.anna wrote:

> @xazax.hun,
>
> Can we move this out of alpha?
>
> Have this checkers been tested on a large codebase? What are false positive rates?


I have tested it on a few ~200k LOC C codebase and I did not see any major problem. There is one problem left though, when I committed this check some of the build bots broke, I suspect that slightly different AST is generated on some of the platforms. I temporarily fixed the issue by hardcoding the triple into the tests and I did not have time yet to investigate the source of the problems. But as far as I remember, this produced false negatives in the tests not false positives.


Repository:
  rL LLVM

https://reviews.llvm.org/D15227





More information about the cfe-commits mailing list