[PATCH] D28785: Split exception.cpp and new.cpp implementation into different files for different runtimes

Eric Fiselier via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Thu Feb 9 21:26:40 PST 2017


EricWF added a comment.

In https://reviews.llvm.org/D28785#673227, @smeenai wrote:

> Still not a fan of the amount of vcruntime dependencies this is taking on, but I guess that can be followed up on.


Neither am I. However this gets the debug build working, and fixes RTTI, which in turn gets a ton of tests passing.
Now we have regression tests for when we start removing vcruntime dependencies.

> Was the `get_new_handler`/`set_new_handler` issue resolved? (The issue being that those functions are in msvcprt, which our tests were silently linking against statically).

Not yet. I'll address that in another patch, and then also enable the aligned new/delete overloads.


https://reviews.llvm.org/D28785





More information about the cfe-commits mailing list