[PATCH] D29419: [Analyzer] Checker for mismatched iterators

[Balogh, Ádám via Phabricator via cfe-commits]

baloghadamsoftware added a comment.

In https://reviews.llvm.org/D29419#671839, @NoQ wrote:

> This one looks similar to the `IteratorPastEnd` checker, so much that i'd definitely advice re-using some code. At the very least, functions like `isIterator()` should definitely deserve a header somewhere in `include/clang/StaticAnalyzer/Checkers`.
>
> Also, did you consider merging these checkers together into one file? Just because they have so much in common.


Yes. Actually these two checkers served for me as prototypes, but it turned out quite early that if I want to implement the most important iterator checker, thus the checker for invalidated iterators it requires a tracker structure that includes all the data we need for these two checkers. So it would be a wast of resources to duplicate these data. So now I am also working on the merged version.


https://reviews.llvm.org/D29419