[PATCH] D29748: [cxx1z-constexpr-lambda] Implement captures - thus completing implementation of constexpr lambdas.
    Faisal Vali via Phabricator via cfe-commits 
    cfe-commits at lists.llvm.org
       
    Wed Feb  8 21:05:55 PST 2017
    
    
  
faisalv added inline comments.
================
Comment at: lib/AST/ExprConstant.cpp:5061
+          APValue RVal;
+          // FIXME: We need to make sure we're passing the right type that
+          // maintains cv-qualifiers.
----------------
I don't think we need this fixme - the type of the expression should be correct - all other const checks for mutability have already been performed, right?
================
Comment at: lib/AST/ExprConstant.cpp:5486
+      }
+      //Info.FFDiag(E);
+      return false;
----------------
I need to delete this comment...
Repository:
  rL LLVM
https://reviews.llvm.org/D29748
    
    
More information about the cfe-commits
mailing list