[PATCH] D29621: Add ASTMatchRefactorer and ReplaceNodeWithTemplate to RefactoringCallbacks

[Julian Bangert via Phabricator via cfe-commits]

jbangert marked 5 inline comments as done.
jbangert added a comment.

Thank you for the initial feedback!



================
Comment at: include/clang/Tooling/RefactoringCallbacks.h:61
+    MatchFinder.addMatcher(Matcher, Callback);
+    Callbacks.emplace_back(Callback);
+  }
----------------
sbenza wrote:
> Why emplace_back instead of push_back?
Changed to push_back.  Is there ever an advantage to using push_back over emplace_back (the latter falls back to a copy constructor). 


https://reviews.llvm.org/D29621