[PATCH] D29221: clang-format-vsix: "format on save" feature

Manuel Klimek via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Tue Feb 7 02:37:22 PST 2017


klimek added a reviewer: hans.
klimek added a comment.

+hans

+1 to "format only current document but save all" not making much sense :)



================
Comment at: tools/clang-format-vs/ClangFormat/TypeConverterUtils.cs:7
+{
+    public sealed class TypeConverterUtils
+    {
----------------
Perhaps name this "TypeConversion" or something - I find "utils" as part of a name to not add anything, and it tends to accumulate cruft :)


================
Comment at: tools/clang-format-vs/ClangFormat/VsixUtils.cs:13
+{
+    internal sealed class VsixUtils
+    {
----------------
Same here, just call it Vsix? (context seems clear enough)


https://reviews.llvm.org/D29221





More information about the cfe-commits mailing list