[PATCH] D28451: [AVR] Add support for the 'interrupt' and 'naked' attributes

Dylan McKay via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Mon Feb 6 23:09:38 PST 2017


dylanmckay added inline comments.


================
Comment at: test/CodeGen/avr/attributes/interrupt.c:3
+
+// CHECK: define void @foo() #0
+__attribute__((interrupt)) void foo(void) { }
----------------
aaron.ballman wrote:
> dylanmckay wrote:
> > aaron.ballman wrote:
> > > As should this.
> > It seems like this sort of test _does_ sit in `CodeGen` - see `test/CodeGen/{arm-interrupt-attr.c|mips-interrupt-attr.c}`.
> > 
> You're correct, this test does belong here. I think I attached my comment to the wrong thing (sorry about that).
No problems, thanks for the review!


https://reviews.llvm.org/D28451





More information about the cfe-commits mailing list