[PATCH] D28365: [Driver] Updated for Visual Studio 2017

[Hamza Sood via Phabricator via cfe-commits]

hamzasood updated this revision to Diff 86900.
hamzasood added a comment.

In https://reviews.llvm.org/D28365#665183, @rnk wrote:

> I had to revert this because it doesn't pass tests on Linux. Can you look into that and resubmit after fixing those test failures?


Really sorry about that, I stupidly only ran the tests on Windows.
The problem was caused by a change in behaviour when Clang is unable to find a Visual Studio installation. This patch made it emit an error and abort compilation in an attempt to be user friendly, which interferes with some tests if triggered (e.g. on Linux where there's no Visual Studio to find).
I've updated it to only emit a warning and continue compilation as usual, which seemed like a better option than removing it completely.


https://reviews.llvm.org/D28365

Files:
  include/clang/Basic/DiagnosticDriverKinds.td
  lib/Driver/MSVCToolChain.cpp
  lib/Driver/ToolChains.h
  lib/Driver/Tools.cpp
  test/Driver/cl-link-at-file.c

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D28365.86900.patch
Type: text/x-patch
Size: 35047 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20170202/3d980917/attachment-0001.bin>