[PATCH] D29151: [clang-tidy] Add misc-invalidated-iterators check.

[Eugene Zelenko via Phabricator via cfe-commits]

Eugene.Zelenko added a comment.

> I think we need some sort of clear guidelines on where what functionality should be added. Even right now there are clang-tidy checks that finds subset of alpha checks, but probably having lower false positive rate. The other example is Use after move, that is doing similar thing as uninitialized values analysis in clang.

I agree with this and could add that we also need similar guidelines for Clang diagnostics too. Some of Clang-tidy and Static Analyzer checks are more suited for Clang diagnostics (unused constructs, deadcode.DeadStores, etc). It will be reasonable if we have discussions to decide better place for particular check instead of just swallowing patches.


Repository:
  rL LLVM

https://reviews.llvm.org/D29151