[PATCH] D28889: Change where we handle arg-dependent diagnose_if attributes

[George Burgess IV via Phabricator via cfe-commits]

george.burgess.iv added a comment.

Thanks for the feedback!



================
Comment at: lib/Sema/SemaChecking.cpp:2520
+
+// TODO: Call can technically be a const CallExpr, but const_casting feels ugly,
+// and I really don't want to duplicate unwrapCallExpr's logic. No caller really
----------------
aaron.ballman wrote:
> Thank you for this comment; I was about to ask about that very topic. :-D
ᕕ( ᐛ )ᕗ

Makes me kinda wish there was a clean way to say "the constness of the returned value depends on the constness of this arg," though. (For values of clean that don't involve some `constness_of<ArgTy, RetTy>::type` kind of thing)


https://reviews.llvm.org/D28889