[PATCH] D28299: Module: use PCMCache to manage memory buffers for pcm files.

[Bruno Cardoso Lopes via Phabricator via cfe-commits]

bruno added inline comments.


================
Comment at: lib/Serialization/ASTReader.cpp:3692
+                            ValidationConflicts);
+    for (auto N : ValidationConflicts)
+      Diag(diag::err_module_ancestor_conflict) << N;
----------------
This should honor `ARR_OutOfDate`, so that the module can be rebuilt in case a user module mismatch via a different diagnostics (lib/Serialization/ASTReader.cpp:4076) and returns OutOfDate instead of Success:

    if ((ClientLoadCapabilities & ARR_OutOfDate) == 0)
      for (auto N : ValidationConflicts)
        Diag(diag::err_module_ancestor_conflict) << N;


https://reviews.llvm.org/D28299