[PATCH] D29032: [mips] Define macros related to -mabicalls in the preprocessor

Simon Dardis via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Tue Jan 24 14:13:14 PST 2017


sdardis added a comment.

@joerg , @emaste : My concern is that the stock gcc distributions for FreeBSD, NetBSD from your sources doesn't define __mips_abicalls, so I'm worried about potential incompatibilities.



================
Comment at: test/Preprocessor/init.c:4533
+// MIPS-ABICALLS-NETBSD64: #define __ABICALLS__ 1
+// MIPS-ABICALLS-NETBSD-NOT: #define __mips_abicalls 1
+//
----------------
Nit to self: this should be MIPS-ABICALLS-NETBSD64-NOT. Likewise for FREEBSD64 and OPENBSD64.


https://reviews.llvm.org/D29032





More information about the cfe-commits mailing list