[PATCH] D29063: [libcxx] Never use <cassert> within libc++

Asiri Rathnayake via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Tue Jan 24 04:31:16 PST 2017


rmaprath added a comment.

@EricWF: My downstream builds have `-DLLVM_ENABLE_ASSERTIONS=ON` by default and they are showing some failures after this commit. Log attached:

F3019711: log.txt <https://reviews.llvm.org/F3019711>

It should be pretty easy to reproduce these (I'm on Ubuntu 16.04) if you enable assertions. Since the default has changed, the public builders won't be seeing these.

Are these failures expected?

Thanks.

/ Asiri


https://reviews.llvm.org/D29063





More information about the cfe-commits mailing list