[PATCH] D29063: [libcxx] Never use <cassert> within libc++

Eric Fiselier via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Mon Jan 23 17:39:34 PST 2017


EricWF created this revision.
Herald added a subscriber: mgorny.

It is my opinion that libc++ should never use `<cassert>`, including in the `dylib`. This patch remove all uses of `assert` from within libc++ and replaces most of them with `_LIBCPP_ASSERT` instead.

Additionally this patch turn `LIBCXX_ENABLE_ASSERTIONS`  off by default, because the standard library should not be aborting user programs unless explicitly asked to.


https://reviews.llvm.org/D29063

Files:
  CMakeLists.txt
  include/__config
  include/__threading_support
  src/condition_variable.cpp
  src/experimental/filesystem/path.cpp
  src/mutex.cpp
  src/system_error.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D29063.85504.patch
Type: text/x-patch
Size: 4758 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20170124/4dd8a5cb/attachment.bin>


More information about the cfe-commits mailing list