[PATCH] D28814: [OpenCL] Add missing address spaces in IR generation of Blocks

[Yaxun Liu via Phabricator via cfe-commits]

yaxunl added inline comments.


================
Comment at: lib/CodeGen/CGBlocks.cpp:723
+                            ? CGM.getNSConcreteStackBlock()
+                            : llvm::Constant::getNullValue(
+                                  CGM.getNSConcreteStackBlock()->getType());
----------------
should use CGM.getNullPointer to create a null pointer.


================
Comment at: lib/CodeGen/CGBlocks.cpp:1124
+                 ? CGM.getNSConcreteGlobalBlock()
+                 : llvm::Constant::getNullValue(
+                       CGM.getNSConcreteGlobalBlock()->getType()));
----------------
should use CGM.getNullPointer to create a null pointer.


https://reviews.llvm.org/D28814