[PATCH] D28849: [compiler-rt] [test] Fix page address logic in clear_cache_test

Saleem Abdulrasool via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Thu Jan 19 20:24:04 PST 2017


compnerd added inline comments.


================
Comment at: test/builtins/Unit/clear_cache_test.c:71
+    char* start = (char*)((uintptr_t)execution_buffer & (-get_page_size()));
+    char* end = (char*)((uintptr_t)(&execution_buffer[128+4096]) & (-get_page_size()));
 #if defined(_WIN32)
----------------
Shouldnt this read:

    char *end = (char *)((uintptr_t)(&execution_buffer[128 + get_page_size()] & (-get_page_size())));


https://reviews.llvm.org/D28849





More information about the cfe-commits mailing list