[PATCH] D28924: [AST Printer] Print attributes on enum constants

Aaron Ballman via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Thu Jan 19 17:36:40 PST 2017

aaron.ballman added a comment.

In https://reviews.llvm.org/D28924#651139, @jordan_rose wrote:

> Interestingly, this case doesn't actually work yet; we unconditionally print enum attributes after the close-brace even though that's not valid for C++ attributes. Do you think I should change that as well, or just land this patch as is?

This is a pervasive issue with attributes, now that I put my thinking cap on. I think you're fine to land it as-is; we need a much larger fix to handle pretty printing attributes properly for all flavors.



More information about the cfe-commits mailing list