[PATCH] D28451: [AVR] Add support for the 'interrupt' and 'naked' attributes

Dylan McKay via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Thu Jan 19 15:51:04 PST 2017

dylanmckay added inline comments.

Comment at: lib/Sema/SemaDeclAttr.cpp:5145
+    if (!isFunctionOrMethod(D)) {
+      S.Diag(D->getLocation(), diag::warn_attribute_wrong_decl_type)
+          << "'interrupt'" << ExpectedFunctionOrMethod;
I'm pretty sure that this check shouldn't be necessary, because we define `Subjects = [Function]` in TableGen.

Without it though, the warning doesn't appear. Do you know why that is @aaron.ballman?


More information about the cfe-commits mailing list