[PATCH] D28451: [AVR] Add support for the 'interrupt' and 'naked' attributes

Dylan McKay via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Thu Jan 19 15:44:22 PST 2017


dylanmckay updated this revision to Diff 85051.
dylanmckay marked 5 inline comments as done.
dylanmckay added a comment.

Code review from Aaron

- Use 'handleSimpleAttribute' rather than duplicating it
- Use 'auto' where a type is explicitly casted
- Add warnings for when the attribute is not on a function
- Add sema tests for when the attr is not on a function


https://reviews.llvm.org/D28451

Files:
  include/clang/Basic/Attr.td
  include/clang/Basic/AttrDocs.td
  lib/CodeGen/TargetInfo.cpp
  lib/Sema/SemaDeclAttr.cpp
  test/CodeGen/avr/attributes/interrupt.c
  test/CodeGen/avr/attributes/naked.c
  test/CodeGen/avr/attributes/signal.c
  test/Sema/avr-interrupt-attr.c
  test/Sema/avr-signal-attr.c

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D28451.85051.patch
Type: text/x-patch
Size: 7238 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20170119/c98f5cb7/attachment.bin>


More information about the cfe-commits mailing list