[PATCH] D28514: [CodeCompletion] Reset the hidden declaration obtained after lookup when caching UsingShadowDecls

Akira Hatanaka via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Thu Jan 19 12:02:24 PST 2017

ahatanak added a comment.

Looks good to me, but one more comment/question.

Comment at: lib/Sema/SemaLookup.cpp:3433
+      // is not hidden by the using declaration.
+      if (isa<UsingShadowDecl>(ND) && isa<UsingDecl>(D))
+        continue;
Do we have to check that ND's UsingDecl is equal to D? Or we don't have to worry about it?



More information about the cfe-commits mailing list