[PATCH] D28667: [clang-tidy] Don't modernize-raw-string-literal if replacement is longer.
Richard via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Thu Jan 19 10:33:04 PST 2017
LegalizeAdulthood added a comment.
In https://reviews.llvm.org/D28667#650586, @leanil wrote:
> In https://reviews.llvm.org/D28667#650585, @LegalizeAdulthood wrote:
> > In https://reviews.llvm.org/D28667#649626, @LegalizeAdulthood wrote:
> > > Don't do this without introducing an option to turn it off.
> > To clarify my reasoning:
> > You imposing your subjective idea of goodness on the code, i.e. style. Other people will have different ideas about what they want from the code. So, to quote the X Window System Maxim, provide tools not rules. Allow people to say whether or not they want the raw string literal in this case.
> I agree. Which mode do you think should be the default?
As long as you can control it, I don't think it matters much and preference of the submitter is fine.
More information about the cfe-commits