[PATCH] D28862: [compiler-rt] [test] Use approximate comparison on float types

Steve Canon via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Thu Jan 19 07:01:24 PST 2017

scanon added a comment.

These tests should either be exact, or should have a tolerance that's mathematically sound. +/-1ulp is not sound; the allowed error should be proportional to the magnitude of the larger of the real and imaginary components of the result -- e.g. if one component is very small compared to the other, the smaller one may have *no* "correct" bits and still be acceptable.



More information about the cfe-commits mailing list