[PATCH] D28843: IRGen: Start using the WriteThinLTOBitcode pass.

[Teresa Johnson via Phabricator via cfe-commits]

tejohnson added a comment.

> TODO: avoid breaking Darwin.

How does this break Darwin?



================
Comment at: clang/lib/CodeGen/BackendUtil.cpp:694
+    else
+      PerModulePasses.add(
+          createBitcodeWriterPass(*OS, CodeGenOpts.EmitLLVMUseLists));
----------------
Can we transform other callers of createBitcodeWriterPass with EmitSummaryIndex = true or EmitModuleHash = true to instead call createWriteThinLTOBitcodePass as you did here, and then remove those parameters from createBitcodeWriterPass?


================
Comment at: clang/test/CodeGenCXX/type-metadata-thinlto.cpp:2
+// RUN: %clang_cc1 -flto=thin -triple x86_64-unknown-linux -fvisibility hidden -emit-llvm-bc -o %t %s
+// RUN: llvm-modextract -o - -n 1 %t | llvm-dis | FileCheck %s
+
----------------
Is it the case that now we will always split the module with this change? Should that only be done under CFI options?


https://reviews.llvm.org/D28843