[libcxx] r292281 - [libcxx] [test] Don't ask whether Incomplete& can be assigned to.

Stephan T. Lavavej via cfe-commits cfe-commits at lists.llvm.org
Tue Jan 17 14:24:45 PST 2017


Author: stl_msft
Date: Tue Jan 17 16:24:45 2017
New Revision: 292281

URL: http://llvm.org/viewvc/llvm-project?rev=292281&view=rev
Log:
[libcxx] [test] Don't ask whether Incomplete& can be assigned to.

This is the subject of an active NB comment. Regardless of what the Working
Paper currently says, asking this question is morally wrong, because the
answer can change when the type is completed. C1XX now detects such
precondition violations and complains about them; perhaps Clang should too.

Fixes D28591.

Modified:
    libcxx/trunk/test/std/utilities/meta/meta.unary/meta.unary.prop/is_assignable.pass.cpp

Modified: libcxx/trunk/test/std/utilities/meta/meta.unary/meta.unary.prop/is_assignable.pass.cpp
URL: http://llvm.org/viewvc/llvm-project/libcxx/trunk/test/std/utilities/meta/meta.unary/meta.unary.prop/is_assignable.pass.cpp?rev=292281&r1=292280&r2=292281&view=diff
==============================================================================
--- libcxx/trunk/test/std/utilities/meta/meta.unary/meta.unary.prop/is_assignable.pass.cpp (original)
+++ libcxx/trunk/test/std/utilities/meta/meta.unary/meta.unary.prop/is_assignable.pass.cpp Tue Jan 17 16:24:45 2017
@@ -82,5 +82,4 @@ int main()
 
 //  pointer to incomplete template type
 	test_is_assignable<X<D>*&, X<D>*> ();
-    test_is_not_assignable<Incomplete&, Incomplete const&>();
 }




More information about the cfe-commits mailing list