[PATCH] D28514: [CodeCompletion] Reset the hidden declaration obtained after lookup when caching UsingShadowDecls
Akira Hatanaka via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Tue Jan 17 13:05:23 PST 2017
ahatanak added inline comments.
Comment at: lib/Sema/SemaCodeComplete.cpp:961
+ // then incorrectly applied to the target declaration. This can be avoided
+ // by resetting the declaration that's being hidden.
+ if (Hiding && isa<UsingDecl>(Hiding))
I'm not sure about this, but is it correct for VisibleDeclsRecord::checkHidden to return the UsingDecl when the UsingShadowDecl is being passed? I'm thinking perhaps the bug is in that function, since it seems like it should just return a nullptr instead if UsingDecl doesn't hide UsingShadowDecl, .
More information about the cfe-commits