[PATCH] D26649: [CMake] Support lld with LTO bootstrap

Petr Hosek via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Tue Jan 17 12:09:14 PST 2017


phosek added inline comments.


================
Comment at: cfe/trunk/CMakeLists.txt:531
+      if(BOOTSTRAP_LLVM_ENABLE_LLD)
+        add_dependencies(clang-bootstrap-deps lld)
+      elseif(LLVM_BINUTILS_INCDIR)
----------------
beanz wrote:
> mehdi_amini wrote:
> > I come back to this a bit late, sorry, but I'm not sure I understand why this dependency on the bootstrap happens only when LTO is used?
> > 
> We should probably separate `LLVM_ENABLE_LTO` and `LLVM_ENABLE_LLD`. You can use LLD without LTO on a wider variety of platforms (including OS X), and you might want to use LLD without LTO.
Yes, this is unnecessarily restrictive; see D28821.


Repository:
  rL LLVM

https://reviews.llvm.org/D26649





More information about the cfe-commits mailing list