[PATCH] D28785: Split exception.cpp and new.cpp implementation into different files for different runtimes

Eric Fiselier via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Tue Jan 17 01:51:37 PST 2017

EricWF added inline comments.

Comment at: include/new:177
+#if !defined(_LIBCPP_ABI_MICROSOFT)
EricWF wrote:
> smeenai wrote:
> > Might be helpful to have a comment explaining why we wanna defer these to msvcrt on Windows?
> > 
> > Also, VS 2015 doesn't seem to have the sized and aligned allocation and deallocation functions. I haven't checked 2017.
> You're right that `VS 2015` doesn't have aligned `new/delete`. However until we can correctly implement `get_new_handler` we won't be able to correctly implement the additional aligned `new/delete` overloads.
I failed to mention that I do plan to re-enable the aligned allocation overloads in the future; But before I do that I need a definition of `std::get_new_handler` which IDK how to provide yet. I've emailed the MSVC team asking for advice about implementing this.


More information about the cfe-commits mailing list