[PATCH] D25208: [libc++] Make _LIBCPP_TYPE_VIS export members

Shoaib Meenai via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Mon Jan 16 23:23:33 PST 2017

smeenai added a comment.

In https://reviews.llvm.org/D25208#647743, @EricWF wrote:

> Actually I probably shouldn't have approved this due to http://llvm.org/PR30642. I forgot about that when I last reviewed this.

Yup. I wrote https://github.com/smeenai/bad-visibility-finder to find all problematic instances, and https://reviews.llvm.org/D27430 fixes all the issues caused by this diff (I haven't gotten around to addressing the comments on that yet).


More information about the cfe-commits mailing list