[PATCH] D28728: [libc++] Introduce _LIBCPP_EXTERN_VIS to fix __libcpp_debug_function link errors
Eric Fiselier via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Mon Jan 16 13:11:09 PST 2017
EricWF accepted this revision.
EricWF added a comment.
This revision is now accepted and ready to land.
In https://reviews.llvm.org/D28728#646489, @smeenai wrote:
> This will need to be exported on other platforms too when hidden visibility happens :)
Are you sure?I don't think "extern" variables are subject to visibility rules in GCC or Clang. At least I haven't
been able to generate a test case or even different assembly.
> Is it okay for these to be exported unconditionally, or should their exporting be determined by `_LIBCPP_DEBUG`? This LGTM if it's the former.
Unconditionally. The declaration should already be `#ifdef`'ed out when libc++'s debug mode is not enabled.
I'm going to commit this as-is, and will address visibility issues on other platforms if needed.
More information about the cfe-commits