[libcxxabi] r292135 - Mark the dynamic-exception tests as unsupported under C++17, since it has no dynamic-exception specs. Also, remove a FIXME workaround from the config that allowed these tests to work under C++17. This addresses PR#31621.

Marshall Clow via cfe-commits cfe-commits at lists.llvm.org
Mon Jan 16 07:28:03 PST 2017


Author: marshall
Date: Mon Jan 16 09:28:03 2017
New Revision: 292135

URL: http://llvm.org/viewvc/llvm-project?rev=292135&view=rev
Log:
Mark the dynamic-exception tests as unsupported under C++17, since it has no dynamic-exception specs. Also, remove a FIXME workaround from the config that allowed these tests to work under C++17. This addresses PR#31621.

Modified:
    libcxxabi/trunk/test/libcxxabi/test/config.py
    libcxxabi/trunk/test/unwind_02.pass.cpp
    libcxxabi/trunk/test/unwind_03.pass.cpp
    libcxxabi/trunk/test/unwind_04.pass.cpp
    libcxxabi/trunk/test/unwind_05.pass.cpp

Modified: libcxxabi/trunk/test/libcxxabi/test/config.py
URL: http://llvm.org/viewvc/llvm-project/libcxxabi/trunk/test/libcxxabi/test/config.py?rev=292135&r1=292134&r2=292135&view=diff
==============================================================================
--- libcxxabi/trunk/test/libcxxabi/test/config.py (original)
+++ libcxxabi/trunk/test/libcxxabi/test/config.py Mon Jan 16 09:28:03 2017
@@ -55,10 +55,6 @@ class Configuration(LibcxxConfiguration)
         if not self.get_lit_bool('enable_threads', True):
             self.cxx.compile_flags += ['-D_LIBCXXABI_HAS_NO_THREADS']
             self.config.available_features.add('libcxxabi-no-threads')
-        # FIXME: Fix the unwind_* tests that test dynamic exception
-        # specifications so they work in C++17 (or always test in C++14).
-        # Suppressing this warning is a temporary workaround.
-        self.cxx.addWarningFlagIfSupported('-Wno-dynamic-exception-spec')
         super(Configuration, self).configure_compile_flags()
     
     def configure_compile_flags_header_includes(self):

Modified: libcxxabi/trunk/test/unwind_02.pass.cpp
URL: http://llvm.org/viewvc/llvm-project/libcxxabi/trunk/test/unwind_02.pass.cpp?rev=292135&r1=292134&r2=292135&view=diff
==============================================================================
--- libcxxabi/trunk/test/unwind_02.pass.cpp (original)
+++ libcxxabi/trunk/test/unwind_02.pass.cpp Mon Jan 16 09:28:03 2017
@@ -8,6 +8,7 @@
 //===----------------------------------------------------------------------===//
 
 // UNSUPPORTED: libcxxabi-no-exceptions
+// REQUIRES-ANY: c++98, c++03, c++11, c++14
 
 #include <assert.h>
 

Modified: libcxxabi/trunk/test/unwind_03.pass.cpp
URL: http://llvm.org/viewvc/llvm-project/libcxxabi/trunk/test/unwind_03.pass.cpp?rev=292135&r1=292134&r2=292135&view=diff
==============================================================================
--- libcxxabi/trunk/test/unwind_03.pass.cpp (original)
+++ libcxxabi/trunk/test/unwind_03.pass.cpp Mon Jan 16 09:28:03 2017
@@ -8,6 +8,7 @@
 //===----------------------------------------------------------------------===//
 
 // UNSUPPORTED: libcxxabi-no-exceptions
+// REQUIRES-ANY: c++98, c++03, c++11, c++14
 
 #include <exception>
 #include <stdlib.h>

Modified: libcxxabi/trunk/test/unwind_04.pass.cpp
URL: http://llvm.org/viewvc/llvm-project/libcxxabi/trunk/test/unwind_04.pass.cpp?rev=292135&r1=292134&r2=292135&view=diff
==============================================================================
--- libcxxabi/trunk/test/unwind_04.pass.cpp (original)
+++ libcxxabi/trunk/test/unwind_04.pass.cpp Mon Jan 16 09:28:03 2017
@@ -8,6 +8,7 @@
 //===----------------------------------------------------------------------===//
 
 // UNSUPPORTED: libcxxabi-no-exceptions
+// REQUIRES-ANY: c++98, c++03, c++11, c++14
 
 #include <exception>
 #include <stdlib.h>

Modified: libcxxabi/trunk/test/unwind_05.pass.cpp
URL: http://llvm.org/viewvc/llvm-project/libcxxabi/trunk/test/unwind_05.pass.cpp?rev=292135&r1=292134&r2=292135&view=diff
==============================================================================
--- libcxxabi/trunk/test/unwind_05.pass.cpp (original)
+++ libcxxabi/trunk/test/unwind_05.pass.cpp Mon Jan 16 09:28:03 2017
@@ -8,6 +8,7 @@
 //===----------------------------------------------------------------------===//
 
 // UNSUPPORTED: libcxxabi-no-exceptions
+// REQUIRES-ANY: c++98, c++03, c++11, c++14
 
 #include <exception>
 #include <stdlib.h>




More information about the cfe-commits mailing list