[PATCH] D28725: [libc++][CMake] Use debug MSVC runtimes when libc++ is built in debug mode

[Eric Fiselier via Phabricator via cfe-commits]

EricWF added inline comments.


================
Comment at: CMakeLists.txt:394
 # non-debug DLLs
 remove_flags("/D_DEBUG" "/MTd" "/MDd" "/MT" "/Md" "/RTC1")
 
----------------
smeenai wrote:
> EricWF wrote:
> > smeenai wrote:
> > > We should be able to remove this now, right?
> > I would still rather strip it and re-add it. Just incase it gets added by LLVM or another parent project.
> Not completely sure I understand. Isn't this gonna be coming from cmake itself?
Yes, that was the original reason. Although it's possible an evil user could also add it.

I would rather handle it manually instead of depending on implicit default flags.


https://reviews.llvm.org/D28725