[PATCH] D21675: New ODR checker for modules
Richard Smith via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Fri Jan 13 12:01:49 PST 2017
rsmith accepted this revision.
rsmith added a comment.
This revision is now accepted and ready to land.
Thanks, looks good assuming your performance testing doesn't uncover anything.
Comment at: lib/AST/ODRHash.cpp:319-321
+ if (!D) return;
+ if (D->isImplicit())
I think you can remove these lines: no-one should be calling this function with a null declaration or an implicit declaration.
More information about the cfe-commits