[PATCH] D28365: [Driver] Updated for Visual Studio 2017

Reid Kleckner via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Fri Jan 13 11:56:47 PST 2017

rnk added inline comments.

Comment at: lib/Driver/MSVCToolChain.cpp:34
+  #if 0
+    #define USE_VS_SETUP_CONFIG
+  #endif
What are the outstanding issues preventing you from enabling this by default?

Comment at: lib/Driver/MSVCToolChain.cpp:160
+    NotAToolChain:
+      ;
I think it would be clearer if you separated out the PATH search into a separate helper. 

Comment at: lib/Driver/MSVCToolChain.cpp:263
+  ;
Similarly, I think this should be a separate helper. It wouldn't need goto.


More information about the cfe-commits mailing list